PWA + offline #325

geekgonecrazy · 2022-01-30T21:29:16Z

I know this project seems to be abandoned. But contributing on the off chance that you pick it up. Based on #296 but this makes it work fully disconnected and caches some bookmarks for offline viewing making it more pocket like and useful

symgryph · 2022-02-06T01:09:44Z

Looks like we are back in business. You might want to take a look again. New maintainer!

geekgonecrazy · 2022-02-18T05:18:55Z

Ah fantastic! Hopefully things pick back up. So far just this change has made it very useful to. Just pin to Home Screen on mobile and can read even with no internet connection :)

fmartingr

Hey @geekgonecrazy, thanks for the PR! This seems amazing. I'm not currently using Shori on my mobile/tablet but this will make it very useful when traveling around.

I'm not very proficent in the front-side of things, so my not-very-expert eyes say it's almost good to go. The only thing I didn't like quite much is that we are serving static assets from the service and also fetching them from the outside. It would be good if we serve those all ourselves.

I know there's a lot of room to improve here, but we need to take it one step at a time.

CC: @m-bers as the original contributor for the PWA

fmartingr · 2022-02-18T18:17:51Z

internal/view/index.html

+		}
+	</script>
+	<script type="module">
+		import 'https://cdn.jsdelivr.net/npm/@pwabuilder/pwaupdate';


Can we have this living with our other static assets? It seems weird to me that we serve everything bundled withing the binary but this is fetched from an outside service.

fmartingr · 2022-02-18T18:19:03Z

internal/view/pwabuilder-sw.js

@@ -0,0 +1,102 @@
+//This is the service worker with the Advanced caching
+
+importScripts('https://storage.googleapis.com/workbox-cdn/releases/5.1.2/workbox-sw.js');


Same as before, can we bundle this within shiori?

fmartingr · 2022-02-18T18:20:09Z

internal/webserver/server.go

@@ -49,6 +49,9 @@ func ServeApp(cfg Config) error {
 		return path.Join(cfg.RootPath, route)
 	}

+	router.GET(jp("/pwabuilder-sw.js"), hdl.serveFile)


This should be served from /js/... as with the other javascript files.

m-bers · 2022-02-23T02:50:34Z

I am just seeing this now--@geekgonecrazy evidently knows more about PWA caching than I do, but I will try to work on the web share target component which was my original aim (offline was just a bonus) and submit that as a separate PR

karlprieb · 2022-05-12T00:32:58Z

Hey @geekgonecrazy 👋 are you still working on this PR? If not I can take a look and make the updates suggested by @fmartingr

geekgonecrazy · 2022-05-20T21:12:36Z

@karlprieb hey my friend! Fancy seeing you here :) I haven't had time to mess with this for a while. I'll add you as contributor on my fork if you want to make more changes.

fmartingr · 2022-10-07T09:24:23Z

Hey @geekgonecrazy, @karlprieb, is this something you are still interested on working on?

stale · 2022-10-17T13:24:05Z

This issue has been automatically marked as stale because it has not had any activity for quite some time.
It will be closed if no further activity occurs.
Thank you for your contributions.

karlprieb · 2022-10-27T16:55:03Z

Hey @fmartingr I’m still interested in working on this feature, sadly I’m not having the necessary time to do so :(

fmartingr · 2022-10-28T06:38:16Z

Hey @karlprieb, no problem, I will just keep this open then. We all have our things in life :)

ilkersigirci · 2023-04-27T14:10:40Z

Any updates about the progress? I think this feature is a game changer for the project.

wolfhechel · 2023-05-22T06:06:23Z

I started working on PWA separate from this pull request and have a working PWA profile and share target but not offline caching. I would be open to reworking my patches with this PR and finish this feature.

geekgonecrazy · 2023-05-24T05:48:22Z

I started working on PWA separate from this pull request and have a working PWA profile and share target but not offline caching. I would be open to reworking my patches with this PR and finish this feature.

Please feel free to take what is done here and wrap into own PR 🙏

Incorporate go-shiori#325 changes, copy assets to static res dir, add json mime type for manifest.json

pythoninthegrass · 2023-07-04T08:23:10Z

No ETA, but I have an MVP working locally in the iOS simulator. Up to the publishing bit now.

fmartingr · 2023-07-04T10:21:59Z

No ETA, but I have an MVP working locally in the iOS simulator. Up to the publishing bit now.

Could it also be used directly from the browser by adding it to home screen/applications without the need of installing an app from the store?

pythoninthegrass · 2023-07-04T16:06:38Z

Good point! Looks like the offline bit will need more testing. PWA portion works pretty well, but the viewport needs adjusting for newer phones without a home button. I'll keep at it 🤙

…

________________________________ From: Felipe Martin ***@***.***> Sent: Tuesday, July 4, 2023 5:22:10 AM To: go-shiori/shiori ***@***.***> Cc: pythoninthegrass ***@***.***>; Manual ***@***.***> Subject: Re: [go-shiori/shiori] PWA + offline (PR #325) No ETA, but I have an MVP working<master...pythoninthegrass:shiori:shiori-mobile> locally in the iOS simulator. Up to the publishing bit<https://docs.pwabuilder.com/#/builder/app-store?id=publishing> now. Could it also be used directly from the browser by adding it to home screen/applications without the need of installing an app from the store? — Reply to this email directly, view it on GitHub<#325 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA7ILP3WON3RSV77TBSSPJLXOPVFFANCNFSM5NEX5UHQ>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Incorporate go-shiori#325 changes, copy assets to static res dir, add json mime type for manifest.json

jt-wang · 2023-09-09T04:01:14Z

@fmartingr @pythoninthegrass Hi there, thanks for all the contribution and discussion! PWA would bring Shiori to next level to fully replace other bookmark managers (especially the default bookmark managers from Chrome and Safari). May I know if this PR is still active? If so, any context of the current blocker preventing it from being merged? Thanks.

fmartingr · 2023-09-09T07:17:43Z

@fmartingr @pythoninthegrass Hi there, thanks for all the contribution and discussion! PWA would bring Shiori to next level to fully replace other bookmark managers (especially the default bookmark managers from Chrome and Safari). May I know if this PR is still active? If so, any context of the current blocker preventing it from being merged? Thanks.

I can't say myself, there are some people interested in moving this forward but sadly since we do this in our free time I guess is difficult to just sit down and go on with it. I also think this would be a game changer but I'm not that into frontend development (if I were, I would refactor all of it 😂 )

pythoninthegrass · 2023-09-09T14:34:55Z

@fmartingr hit the nail on the head. I made some progress but with the latest API changes, it became too much of a lift.

I'm pretty green at go and frontend isn't my strong suit. My fork is still available and the manifest.json (manifest.webmanifest) is about 2/3 complete according to pwabuilder.

Ended up migrating to Omnivore and while it doesn't quite check all the boxes, it suits my needs and has very responsive devs who are actively implementing features I'm interested in.

fmartingr · 2023-09-10T07:21:29Z

@fmartingr hit the nail on the head. I made some progress but with the latest API changes, it became too much of a lift.

I'm pretty green at go and frontend isn't my strong suit. My fork is still available and the manifest.json (manifest.webmanifest) is about 2/3 complete according to pwabuilder.

Ended up migrating to Omnivore and while it doesn't quite check all the boxes, it suits my needs and has very responsive devs who are actively implementing features I'm interested in.

That's sad to hear, but understandable :)

I may hop on to the task then, while I make the changes to the API. Thanks for putting your time into it anyway, really appreciated.

pythoninthegrass · 2023-09-10T10:49:10Z

You're welcome! It was a good learning experience and appreciate what you've done to make a viable pocket alternative ☺️

…

________________________________ From: Felipe Martin ***@***.***> Sent: Sunday, September 10, 2023 2:21:41 AM To: go-shiori/shiori ***@***.***> Cc: pythoninthegrass ***@***.***>; Mention ***@***.***> Subject: Re: [go-shiori/shiori] PWA + offline (PR #325) @fmartingr<https://github.com/fmartingr> hit the nail on the head. I made some progress but with the latest API changes, it became too much of a lift. I'm pretty green at go and frontend isn't my strong suit. My fork is still available and the manifest.json (manifest.webmanifest) is about 2/3 complete according to pwabuilder<https://www.pwabuilder.com/>. Ended up migrating to Omnivore and while it doesn't quite check all the boxes, it suits my needs and has very responsive devs who are actively implementing features I'm interested in. That's sad to hear, but understandable :) I may hop on to the task then, while I make the changes to the API. Thanks for putting your time into it anyway, really appreciated. — Reply to this email directly, view it on GitHub<#325 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA7ILP5VFYRAFI7PYCBZ5BDXZVTALANCNFSM5NEX5UHQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

ragekit · 2024-05-04T01:06:03Z

Any helper needed ? I wanted to make a simple pwa of shiori just to be able to share links to it, but apparently some work was done here ?
I can checkout this branch and try to fix

fmartingr · 2024-05-10T18:03:10Z

Any helper needed ? I wanted to make a simple pwa of shiori just to be able to share links to it, but apparently some work was done here ? I can checkout this branch and try to fix

Absolutely! The frontend side needs a hand, but if you could bring the PWA to an usable state it would be awesome tbh :)

ragekit · 2024-05-21T20:43:45Z

Maybe a very dumb question but what is the user/pwd of the dev local dev instance ? I can't find it in the doc
EDIT : nvm ! same as fresh install

ragekit · 2024-05-22T20:35:47Z

Lots have changed since the previous devs attempt to add a PWA. I'm trying to from scratch just to add a manifest and I'm a bit confused by the routing system, fonrtend.go seems to says that the assets folder is statically accesible but alas my manifest get 404

fmartingr · 2024-05-22T20:44:33Z

Lots have changed since the previous devs attempt to add a PWA. I'm trying to from scratch just to add a manifest and I'm a bit confused by the routing system, fonrtend.go seems to says that the assets folder is statically accesible but alas my manifest get 404

Yeah, files stored under internal/view/assets are served over at /assets/.... You may need to restart the server for the static file system to handle those.

If you can, submit your PR in draft mode and we can provide assistance in there.

ragekit · 2024-05-22T20:55:12Z

Allright, posted here : #919

stale · 2024-10-28T07:43:20Z

This issue has been automatically marked as stale because it has not had any activity for quite some time.
It will be closed if no further activity occurs.
Thank you for your contributions.

m-bers and others added 3 commits January 24, 2021 12:37

Add PWA service worker, manifest, and assets

9f59508

Fix service worker caching

0bffe11

cache api and html so actually works offline

47a65fc

fmartingr force-pushed the master branch 4 times, most recently from d1ffd75 to d70a8f2 Compare February 10, 2022 21:57

fmartingr mentioned this pull request Feb 18, 2022

Add PWA service worker, manifest, and assets #296

Closed

fmartingr requested changes Feb 18, 2022

View reviewed changes

fmartingr added the tag:stalebot label Oct 7, 2022

stale bot added the tag:stale label Oct 17, 2022

stale bot closed this Oct 27, 2022

fmartingr reopened this Oct 28, 2022

fmartingr removed tag:stale tag:stalebot labels Oct 28, 2022

fmartingr added the tag:waiting-for-assignee label Mar 5, 2023

pythoninthegrass added a commit to pythoninthegrass/shiori that referenced this pull request Jul 3, 2023

PWA

36f3d0f

Incorporate go-shiori#325 changes, copy assets to static res dir, add json mime type for manifest.json

pythoninthegrass added a commit to pythoninthegrass/shiori that referenced this pull request Jul 11, 2023

PWA

277d2c8

Incorporate go-shiori#325 changes, copy assets to static res dir, add json mime type for manifest.json

fmartingr force-pushed the master branch from 10ea87a to 1d52569 Compare September 11, 2023 17:20

fmartingr mentioned this pull request May 23, 2024

feat: add PWA support #919

Draft

fmartingr added the tag:stalebot label Oct 13, 2024

stale bot added the tag:stale label Oct 28, 2024

stale bot closed this Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PWA + offline #325

PWA + offline #325

geekgonecrazy commented Jan 30, 2022 •

edited

Loading

symgryph commented Feb 6, 2022

geekgonecrazy commented Feb 18, 2022

fmartingr left a comment

fmartingr Feb 18, 2022

fmartingr Feb 18, 2022

fmartingr Feb 18, 2022

m-bers commented Feb 23, 2022

karlprieb commented May 12, 2022

geekgonecrazy commented May 20, 2022 •

edited

Loading

fmartingr commented Oct 7, 2022

stale bot commented Oct 17, 2022

karlprieb commented Oct 27, 2022

fmartingr commented Oct 28, 2022

ilkersigirci commented Apr 27, 2023

wolfhechel commented May 22, 2023

geekgonecrazy commented May 24, 2023

pythoninthegrass commented Jul 4, 2023

fmartingr commented Jul 4, 2023

pythoninthegrass commented Jul 4, 2023 via email

jt-wang commented Sep 9, 2023

fmartingr commented Sep 9, 2023

pythoninthegrass commented Sep 9, 2023

fmartingr commented Sep 10, 2023

pythoninthegrass commented Sep 10, 2023 via email

ragekit commented May 4, 2024 •

edited

Loading

fmartingr commented May 10, 2024

ragekit commented May 21, 2024 •

edited

Loading

ragekit commented May 22, 2024

fmartingr commented May 22, 2024

ragekit commented May 22, 2024

stale bot commented Oct 28, 2024

		@@ -0,0 +1,102 @@
		//This is the service worker with the Advanced caching

		importScripts('https://storage.googleapis.com/workbox-cdn/releases/5.1.2/workbox-sw.js');

PWA + offline #325

PWA + offline #325

Conversation

geekgonecrazy commented Jan 30, 2022 • edited Loading

symgryph commented Feb 6, 2022

geekgonecrazy commented Feb 18, 2022

fmartingr left a comment

Choose a reason for hiding this comment

fmartingr Feb 18, 2022

Choose a reason for hiding this comment

fmartingr Feb 18, 2022

Choose a reason for hiding this comment

fmartingr Feb 18, 2022

Choose a reason for hiding this comment

m-bers commented Feb 23, 2022

karlprieb commented May 12, 2022

geekgonecrazy commented May 20, 2022 • edited Loading

fmartingr commented Oct 7, 2022

stale bot commented Oct 17, 2022

karlprieb commented Oct 27, 2022

fmartingr commented Oct 28, 2022

ilkersigirci commented Apr 27, 2023

wolfhechel commented May 22, 2023

geekgonecrazy commented May 24, 2023

pythoninthegrass commented Jul 4, 2023

fmartingr commented Jul 4, 2023

pythoninthegrass commented Jul 4, 2023 via email

jt-wang commented Sep 9, 2023

fmartingr commented Sep 9, 2023

pythoninthegrass commented Sep 9, 2023

fmartingr commented Sep 10, 2023

pythoninthegrass commented Sep 10, 2023 via email

ragekit commented May 4, 2024 • edited Loading

fmartingr commented May 10, 2024

ragekit commented May 21, 2024 • edited Loading

ragekit commented May 22, 2024

fmartingr commented May 22, 2024

ragekit commented May 22, 2024

stale bot commented Oct 28, 2024

geekgonecrazy commented Jan 30, 2022 •

edited

Loading

geekgonecrazy commented May 20, 2022 •

edited

Loading

ragekit commented May 4, 2024 •

edited

Loading

ragekit commented May 21, 2024 •

edited

Loading